Skip to content

Developer preview note #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 5, 2019
Merged

Developer preview note #13

merged 3 commits into from
Sep 5, 2019

Conversation

yhontyk
Copy link
Contributor

@yhontyk yhontyk commented Sep 3, 2019

Added a note to index.adoc about Piplelines being in Dev Preview

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 3, 2019
nebelsprachen
nebelsprachen reviewed Sep 3, 2019
View reviewed changes
Copy link
Contributor

@nebelsprachen nebelsprachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look's great! I think it is a bit much to be a note. Maybe we can put an IMPORTANT flag and put it at the top of the page, wdyt?

nebelsprachen
nebelsprachen reviewed Sep 3, 2019
View reviewed changes
modules/ROOT/pages/index.adoc Outdated

[NOTE]
====
OpenShift Pipelines is based on the upstream project link:https://github.com/tektoncd[Tekton] and is available as a Developer Preview release. Developer Preview releases have features and functionality that might not be fully tested. Red Hat encourages customers to use and provide feedback on Developer Preview releases especially for development purposes but does not commit to fixing any reported issues and the provided features may not be available in future releases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last sentence seems somewhat verbose; maybe can split it up.

@Preeticp
Copy link
Contributor

Preeticp commented Sep 4, 2019 •
edited
Loading

Look's great! I think it is a bit much to be a note. Maybe we can put an IMPORTANT flag and put it at the top of the page, wdyt?

Agree, let's keep this as close to the OCP docs as possible, add this section after the first paragraph, before the bullet points.
@joaedwar can we render it the way it does here: https://docs.openshift.com/container-platform/4.1/service_mesh/service_mesh_install/understanding-ossm.html

Also, let's add a second level heading for the Dev Preview section titled 'OpenShift Pipelines is a Developer Preview Release' and another Second level heading titled 'Key Features' for the unordered list below. What do you all think?

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 4, 2019
@nebelsprachen nebelsprachen merged commit de34bfc into openshift:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nebelsprachen nebelsprachen nebelsprachen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Peer Review Done size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yhontyk @Preeticp @nebelsprachen @openshift-ci-robot